Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Row with Buttons #32

Open
johntom opened this issue Sep 20, 2013 · 6 comments
Open

Row with Buttons #32

johntom opened this issue Sep 20, 2013 · 6 comments

Comments

@johntom
Copy link

johntom commented Sep 20, 2013

Hi,
I'm trying to add a command column with 3 buttons (new,edit and delete). The following plunker illustrates the ng-click problem as the only the a href="http://www.gtz.com" works.
http://plnkr.co/edit/SKdu8sFRFOt6qg1J1o0n?p=preview
TIA
John

@mlaccetti
Copy link

@johntom - you need to prefix your edit and del functions with 'parent.' - http://plnkr.co/edit/wV8GJOvy37aGdjnlMhuH?p=preview

@johntom
Copy link
Author

johntom commented Dec 11, 2013

Hi Michael,

Unless I'm missing something the edit and del button click event still does not fire. Only the following event works.

<row on-selected="handleRowSelection(row)" ....>

Thanks

John

From: Michael Laccetti [mailto:[email protected]]
Sent: Tuesday, December 10, 2013 11:08 PM
To: davidjnelson/angular-table
Cc: John R. Tomaselli
Subject: Re: [angular-table] Row with Buttons (#32)

@johntom https://github.com/johntom - you need to prefix your edit and del functions with 'parent.' - http://plnkr.co/edit/wV8GJOvy37aGdjnlMhuH?p=preview


Reply to this email directly or view it on GitHub #32 (comment) . https://github.com/notifications/beacon/j9yi2VKYyNfuAJMDa9D7nMwV66TKwwVQFc80-rKkKCPpLyiAMTopxyMY4hUuNoqq.gif


No virus found in this message.
Checked by AVG - www.avg.com
Version: 2014.0.4259 / Virus Database: 3658/6893 - Release Date: 12/05/13

@mlaccetti
Copy link

Not too sure what's going on - I clicked 'edit' on a row, and the form on the right had the data populated. Here's a quick screenshot:

screenshot

@johntom
Copy link
Author

johntom commented Dec 11, 2013

Hi Michael,

The code always worked like that because of

Notice that edit and del buttons are designed to raise an alert.

John

From: Michael Laccetti [mailto:[email protected]]
Sent: Wednesday, December 11, 2013 2:50 PM
To: davidjnelson/angular-table
Cc: John R. Tomaselli
Subject: Re: [angular-table] Row with Buttons (#32)

Not too sure what's going on - I clicked 'edit' on a row, and the form on the right had the data populated. Here's a quick screenshot:

screenshot https://github-camo.global.ssl.fastly.net/b6745f8e4fb9c5fd3e8abb716f33094e8516d674/687474703a2f2f692e696d6775722e636f6d2f3361734475564d2e706e67


Reply to this email directly or view it on GitHub #32 (comment) . https://github.com/notifications/beacon/j9yi2VKYyNfuAJMDa9D7nMwV66TKwwVQFc80-rKkKCPpLyiAMTopxyMY4hUuNoqq.gif


No virus found in this message.
Checked by AVG - www.avg.com
Version: 2014.0.4259 / Virus Database: 3658/6893 - Release Date: 12/05/13

@mlaccetti
Copy link

Looks like you were just using an outdated version of the angularTable.js - I replaced the content with the current one from the repo and it looks good:

image

@johntom
Copy link
Author

johntom commented Dec 11, 2013

Cool. I'll check it out tomorrow and get back to you.

J

From: Michael Laccetti [mailto:[email protected]]
Sent: Wednesday, December 11, 2013 5:22 PM
To: davidjnelson/angular-table
Cc: John R. Tomaselli
Subject: Re: [angular-table] Row with Buttons (#32)

Looks like you were just using an outdated version of the angularTable.js - I replaced the content with the current one from the repo and it looks good:

image https://f.cloud.github.com/assets/135857/1728637/91a498dc-62b2-11e3-85d1-86ac0addda8e.png


Reply to this email directly or view it on GitHub #32 (comment) . https://github.com/notifications/beacon/j9yi2VKYyNfuAJMDa9D7nMwV66TKwwVQFc80-rKkKCPpLyiAMTopxyMY4hUuNoqq.gif


No virus found in this message.
Checked by AVG - www.avg.com
Version: 2014.0.4259 / Virus Database: 3658/6893 - Release Date: 12/05/13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants