Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: new font bugs/changes #71

Open
3 of 5 tasks
penfold42 opened this issue Sep 16, 2024 · 4 comments
Open
3 of 5 tasks

testing: new font bugs/changes #71

penfold42 opened this issue Sep 16, 2024 · 4 comments

Comments

@penfold42
Copy link
Contributor

penfold42 commented Sep 16, 2024

I love the new font!

I've found a couple of issues and i expect there to me more.

  • New font fixes and small UI fixes #72 You broke my animated splash screen! :)

  • New font fixes and small UI fixes #72 lower case f, s and t are offset to the left (already got a fix for it)

  • New font fixes and small UI fixes #72 in the waterfall screen there is some weirdness at the top - some pixels are set above the tick marks

  • settings changes are not applied immediately after exiting (specific) settings screen, but only after exiting to the main screen

  • the 12 wide font specified no gap between chars, the 5 wide font specifies 1px gap. I suspect some of my code like centering might get a bit confused

I'm happy to cover all 3 above. In addition, as part of the scanner work I've been secretly doing, I added another 6 characters to the font. I'll also add them to the big one.

If anyone find other UI weirdness that might be due to the fonts, add em here

@mryndzionek
Copy link
Contributor

mryndzionek commented Sep 16, 2024

Probably unrelated bugs I noticed:

  • in the waterfall screen there is some weirdness at the top - some pixels are set above the tick marks
  • settings changes are not applied immediately after exiting (specific) settings screen, but only after exiting to the main screen

@penfold42
Copy link
Contributor Author

Probably unrelated bugs I noticed:

* [ ]   in the waterfall screen there is some weirdness at the top - some pixels are set above the tick marks

is that the commas rather than decimal points between? other than those I cant see it on mine.

I did also notice that the tick marks on the spectrum view are broken tho!

@mryndzionek
Copy link
Contributor

is that the commas rather than decimal points between? other than those I cant see it on mine.

Yes, so there are commas instead of dots, but also it seems that scrolling starts too high and the commas are "stretched" down. You can see it happening immediately after switching to the waterfall page.

@penfold42
Copy link
Contributor Author

is that the commas rather than decimal points between? other than those I cant see it on mine.

Yes, so there are commas instead of dots, but also it seems that scrolling starts too high and the commas are "stretched" down. You can see it happening immediately after switching to the waterfall page.

With the aid of my phone zoom, this should be fixed in #72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants