Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't automatically run Artifact Schema Check on PRs #11260

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Don't automatically run Artifact Schema Check on PRs #11260

wants to merge 2 commits into from

Conversation

aranke
Copy link
Member

@aranke aranke commented Jan 30, 2025 •
edited
Loading

@aranke aranke requested a review from a team as a code owner January 30, 2025 14:59
@cla-bot cla-bot bot added the cla:yes label Jan 30, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.90%. Comparing base (c042370) to head (72f356a).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11260      +/-   ##
==========================================
+ Coverage   88.87%   88.90%   +0.02%     
==========================================
  Files         187      187              
  Lines       24072    24072              
==========================================
+ Hits        21395    21402       +7     
+ Misses       2677     2670       -7
Flag Coverage Δ
integration 86.22% <ø> (+0.02%) ⬆️
unit 62.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.44% <ø> (ø)
Integration Tests 86.22% <ø> (+0.02%) ⬆️

emmyoop
emmyoop requested changes Jan 30, 2025
View reviewed changes
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just make it a bit more flexible.

.github/workflows/schema-check.yml Show resolved Hide resolved
@aranke aranke requested a review from emmyoop January 30, 2025 17:59
emmyoop
emmyoop approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmyoop emmyoop emmyoop approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aranke @emmyoop