Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/CD Improvements] Standardize and automate formatting for workflows #665

Open
3 tasks
mikealfare opened this issue Aug 7, 2024 · 0 comments · May be fixed by dbt-labs/dbt-postgres#141 or dbt-labs/dbt-postgres#143
Assignees
Labels
community A PR, or an issue with a PR, from a community member feature:cost-reduction Issues related to measuring and reducing execution cost pkg:dbt-postgres Issue affects dbt-postgres

Comments

@mikealfare
Copy link
Contributor

mikealfare commented Aug 7, 2024

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt-postgres functionality, rather than a Big Idea better suited to a discussion

Describe the feature

As a maintainer, I want to automate formatting checks, so that I can focus more on content in PRs and still maintain a code quality standard.

Acceptance Criteria

Preview Give feedback

Formatters:

Linters:

Style standards:

  • Job ids, step ids, and variables are in kebab case
  • Job names, step names, and description fields follow dbt docs standards (capitalize first word only)
  • Extra descriptors should be avoided unless required for disambiguation, e.g.
    • version-number -> version
    • archive-name -> archive
  • Workflow files use a four space tab
  • Scripts (inline or separate files) use environment variables in env instead of inline substitution like ${{ inputs.value }}
@mikealfare mikealfare added type:enhancement New feature request triage:product In Product's queue type:task Eng-driven work and removed type:enhancement New feature request triage:product In Product's queue labels Aug 7, 2024
@mikealfare mikealfare added feature:cost-reduction Issues related to measuring and reducing execution cost community A PR, or an issue with a PR, from a community member and removed type:task Eng-driven work labels Aug 7, 2024
@mikealfare mikealfare self-assigned this Aug 9, 2024
@leahwicz leahwicz linked a pull request Aug 12, 2024 that will close this issue
4 tasks
@leahwicz leahwicz linked a pull request Aug 30, 2024 that will close this issue
@mikealfare mikealfare added the pkg:dbt-postgres Issue affects dbt-postgres label Jan 15, 2025
@mikealfare mikealfare transferred this issue from dbt-labs/dbt-postgres Jan 24, 2025
mikealfare pushed a commit that referenced this issue Jan 29, 2025
* Update ddtrace requirement from ~=2.1 to ~=2.2

Updates the requirements on [ddtrace](https://github.com/DataDog/dd-trace-py) to permit the latest version.
- [Release notes](https://github.com/DataDog/dd-trace-py/releases)
- [Changelog](https://github.com/DataDog/dd-trace-py/blob/2.x/CHANGELOG.md)
- [Commits](DataDog/dd-trace-py@v2.1.0...v2.2.0)

---
updated-dependencies:
- dependency-name: ddtrace
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>

* Add automated changelog yaml from template for bot PR

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Github Build Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community A PR, or an issue with a PR, from a community member feature:cost-reduction Issues related to measuring and reducing execution cost pkg:dbt-postgres Issue affects dbt-postgres
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant