Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Answer file passing to script to modify defaults #24

Open
andiohn opened this issue Jul 30, 2024 · 2 comments
Open

Answer file passing to script to modify defaults #24

andiohn opened this issue Jul 30, 2024 · 2 comments
Labels
good first issue Good for newcomers
Milestone

Comments

@andiohn
Copy link

andiohn commented Jul 30, 2024

What if you directed the bash script to an answer file and then all of your customizations could simply be loaded? I'm thinking Piosk specific ones, nothing extra.

This would be huge because we could have one answer file for all instances, and then it would be selected based on the hostname of the device. This could also mean that we could re-deploy super fast by just maintaining a fresh example. Kind of like Ansible but not really ansible.

I was thinking of having an answer file in like github and then passing the path in the installation path.

@andiohn andiohn changed the title Answer file loading! Answer file passing to script to modify defaults Jul 30, 2024
@andiohn
Copy link
Author

andiohn commented Jul 30, 2024

This would require an established file format and variable names etc.

@debloper
Copy link
Owner

The config.json file does just that & it's structured to be manually editable. That's also specifically why the cleanup script takes a backup of the config.json file to make reinstallation painless.

All you need to do is edit/replace (overwrite) the config file with your custom config file, and reboot.

Keeping the issue open, just in case someone wants to parameterize the config file and pass it on with a flag or environment variable or something to load up the file from a different path/location/protocol etc. But otherwise, this is already taken care of.

@debloper debloper added this to the .NEXT milestone Jul 31, 2024
@debloper debloper added the good first issue Good for newcomers label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants