Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed incorrect pretrained status check in DualPredictor. #52

Merged

Conversation

M-Mouhcine
Copy link
Collaborator

  • Changed pkgutil.find_loader with importlib.util.find_spec as find_loader is deprecated and will be removed in python 3.14.
  • Fixed incorrect check of pretrained status in DualPredictor (and MeanVarPredictor). Wrapped models need to have their is_trained status set to True to consider that DualPredictor (or MeanVarPredictor) is pretrained.

@M-Mouhcine M-Mouhcine linked an issue Mar 8, 2024 that may be closed by this pull request
Soft requirement for scikit-learn version ~=1.3.0.
@M-Mouhcine M-Mouhcine merged commit 3b9e4e5 into main Mar 11, 2024
6 checks passed
@M-Mouhcine M-Mouhcine deleted the 49-bug-instance-variable-is_trained-is-used-incorrectly branch March 13, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Instance variable is_trained is used incorrectly
1 participant