chore: inherit from FilterDocumentsTestWithDataframe in Document Stores
#1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type:documentation
anakin87
changed the title
FilterDocumentsTestWithDataframe in Document Stores
anakin87
commented
Jan 15, 2025
Comment on lines
-409
to
-420
| @pytest.mark.skip(reason="Filter on dataframe contents is not supported.") | ||
| def test_comparison_equal_with_dataframe( | ||
| self, document_store: ChromaDocumentStore, filterable_docs: List[Document] | ||
| ): | ||
| pass | ||
|
|
||
| @pytest.mark.skip(reason="Filter on dataframe contents is not supported.") | ||
| def test_comparison_not_equal_with_dataframe( | ||
| self, document_store: ChromaDocumentStore, filterable_docs: List[Document] | ||
| ): | ||
| pass | ||
|
|
There was a problem hiding this comment.
Chroma does not support dataframes, so in this case I'm not using the new testing class.
It is no longer necessary to skip these tests: they are no longer part of the basic tests.
| documents = create_filterable_docs(include_dataframe_docs=True) | ||
| for i in range(len(documents)): | ||
| if date := documents[i].meta.get("date"): | ||
| documents[i].meta["date"] = f"{date}Z" |
There was a problem hiding this comment.
for Weaviate, I simplified the existing code and added a new filterable_docs_with_dataframe fixture.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
FilterDocumentsTestWithDataframein Document Stores tests after Haystack 2.9.0 release #1280 - explained in the original issueProposed Changes:
FilterDocumentsTestWithDataframe, so that tests on dataframes will keep runningHow did you test it?
CI
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.