Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSR and Client Side Rendering with gfm #126

Open
mcgear opened this issue Aug 13, 2024 · 2 comments
Open

JSR and Client Side Rendering with gfm #126

mcgear opened this issue Aug 13, 2024 · 2 comments

Comments

@mcgear
Copy link

mcgear commented Aug 13, 2024

#119

We use esbuild to compile a control that is delivered to the client. This was previously working, we just upgraded to JSR and now with the latest version of GFM (0.8.2), we are getting error:

Error: Dynamic require of "path" is not supported
    at eacIslandsClient.js?revision=1723577690368:12:9
    at ../../../../../../AppData/Local/deno/deno_esbuild/[email protected]/node_modules/postcss/lib/map-generator.js (map-generator.js:4:43)
    at __require2 (eacIslandsClient.js?revision=1723577690368:18:50)
    at ../../../../../../AppData/Local/deno/deno_esbuild/[email protected]/node_modules/postcss/lib/lazy-result.js (lazy-result.js:4:20)
    at __require2 (eacIslandsClient.js?revision=1723577690368:18:50)
    at ../../../../../../AppData/Local/deno/deno_esbuild/[email protected]/node_modules/postcss/lib/postcss.js (postcss.js:5:18)
    at __require2 (eacIslandsClient.js?revision=1723577690368:18:50)
    at ../../../../../../AppData/Local/deno/deno_esbuild/[email protected]/node_modules/sanitize-html/index.js (index.js:6:33)
    at __require2 (eacIslandsClient.js?revision=1723577690368:18:50)
    at https://jsr.io/@deno/gfm/0.7.0/mod.ts (mod.ts:8:26)

We are in the process of checking older version to see if they work, 0.7.0 does not seem to work either.

@mcgear
Copy link
Author

mcgear commented Aug 13, 2024

Uppon further look, it seems the render is working. The issue happens in mod.ts at this line:

import sanitizeHtml from "npm:sanitize-html@^2.11";

@jpsullivan
Copy link

Yep seeing the same thing over here while attempting to integrate into a small Fresh app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants