fix(cli/hmr): print compile error with exception details #27597
+23
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dsherret
reviewed
Jan 9, 2025
There was a problem hiding this comment.
Nice, this looks good! Would you be able to add a test in this file just to confirm it actually works and so it doesn't regress in the future?
deno/tests/integration/watcher_tests.rs
Line 1729 in ce0968e
dsherret
changed the title
|
Categorizing as a fix so that it can land in a patch release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #27577
It can be improved by adding file and line of the error, as it only displays the error information using
get_message_and_description, example:HMR Failed to reload module file:///file.ts: compile error: Uncaught SyntaxError: Cannot use import statement outside a module - undefined.