Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VETS-API] Finish Rails 8 Upgrade #99428

Open
14 tasks
ryan-mcneil opened this issue Dec 18, 2024 · 0 comments
Open
14 tasks

[VETS-API] Finish Rails 8 Upgrade #99428

ryan-mcneil opened this issue Dec 18, 2024 · 0 comments

Comments

@ryan-mcneil
Copy link
Contributor

ryan-mcneil commented Dec 18, 2024

Finish Rails 8 (8.0.1 currenlty) upgrade that was started in this ticket.

Blockers

  • There's a PR just about ready for activerecord-postgis-adapter to make it compatible with Rails 8
    • Remember to point gemfile back (currently pointed at PR branch to move forward)
  • There's an issue with rails_semantic_logger that's breaking a chunk of specs. This issue is comparable, and here's a PR for a potential fix
    • rspec ./modules/my_health/spec/requests/my_health/v1/medical_records/imaging_spec.rb (1 example, though the failure is different in CI vs locally)
    • rspec ./spec/requests/v0/health_records_spec.rb (3 examples)
    • rspec ./spec/requests/swagger_spec.rb (2 examples)

Follow up tickets

  • [ ]

Tasks

  • Fix remaining broken specs (~20)
  • Address any issues with new test configurations
  • Address any issues with new development configurations
  • Address any issues with new production configurations
  • Fix issues associated with new config.autoload_lib default setting
  • Create Follow up tickets for any TODOs

Acceptance Criteria

  • Rails 8 deployed to Production
  • Follow up tickets created
@ryan-mcneil ryan-mcneil added needs-refinement Identifies tickets that need to be refined platform-reliability-team labels Dec 18, 2024
@ryan-mcneil ryan-mcneil self-assigned this Dec 18, 2024
@ericboehs ericboehs removed the needs-refinement Identifies tickets that need to be refined label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants