Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download Progress Bar #23

Open
MikeGriniezakis opened this issue May 5, 2020 · 7 comments · May be fixed by #685
Open

Download Progress Bar #23

MikeGriniezakis opened this issue May 5, 2020 · 7 comments · May be fixed by #685
Milestone

Comments

@MikeGriniezakis
Copy link

It would make the download progress much easier to understand. You can use rich library for python to make beautiful progress bars.

@derrod
Copy link
Owner

derrod commented May 5, 2020

While the current progress indicator is a placeholder and I do plan on replacing it with a nicer one later, I do not quite understand what is hard to understand about a progress percentage?

@MikeGriniezakis
Copy link
Author

The precentage is fine but I think it has a few unnecessary details for the average user. You can remove these details and make them optional. Also, it would be easier to understand if you can visualise the progress.

@derrod derrod added this to the 0.0.12 milestone May 14, 2020
@artemyto
Copy link

I think it is better to update progress information on the same place, rather than spamming terminal with tons of text. For reference: https://stackoverflow.com/questions/517127/how-do-i-write-output-in-same-place-on-the-console

@John-Gee
Copy link

Agreed to this, filling up the console with such little information is not helpful.

@legendofmiracles
Copy link

legendofmiracles commented Oct 11, 2020

Does the logging library used support this (link)?

Edit: I don't think so...
I am right now looking into using sys.stdout.write to write the text and then update it, i'll show my progress here

Edit 2: I got it working! with enough space it looks like this:
image
and with not enough space, it looks like this
image
with no progress bar :/

I'll work on it a bit more, and then open a PR merging my changes into base.
Any things i should still change before opening a PR @derrod?

@legendofmiracles
Copy link

legendofmiracles commented Oct 16, 2020

So, a few days later...
I've been trying a bit to resize with the terminal, but i've been strugelling A LOT.
It just won't fit with every terminal size.
i think i'll make it a make it a small progress bar, that almost will never fail:
image

EDIT:
I think i got a progress bar to work, that works!
Demonstration in the video
I opened a PR: #126

@zezic
Copy link

zezic commented Nov 23, 2020

Consider using the tqdm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants
@John-Gee @zezic @derrod @legendofmiracles @MikeGriniezakis @artemyto and others