-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download Progress Bar #23
Comments
While the current progress indicator is a placeholder and I do plan on replacing it with a nicer one later, I do not quite understand what is hard to understand about a progress percentage? |
The precentage is fine but I think it has a few unnecessary details for the average user. You can remove these details and make them optional. Also, it would be easier to understand if you can visualise the progress. |
I think it is better to update progress information on the same place, rather than spamming terminal with tons of text. For reference: https://stackoverflow.com/questions/517127/how-do-i-write-output-in-same-place-on-the-console |
Agreed to this, filling up the console with such little information is not helpful. |
Does the logging library used support this (link)? Edit: I don't think so... Edit 2: I got it working! with enough space it looks like this: I'll work on it a bit more, and then open a PR merging my changes into base. |
So, a few days later... EDIT: |
Consider using the tqdm |
It would make the download progress much easier to understand. You can use rich library for python to make beautiful progress bars.
The text was updated successfully, but these errors were encountered: