Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pending refactoring issues #12

Open
EfrainReyes opened this issue Apr 6, 2015 · 0 comments
Open

Pending refactoring issues #12

EfrainReyes opened this issue Apr 6, 2015 · 0 comments
Assignees
@EfrainReyes

Comments

@EfrainReyes
Copy link
Member

1 - Refactor validation logic in attribute classes into validator classes.
2 - Refactor RegExps that are being declared at the instance level into static fields with a Compiled option.
@EfrainReyes EfrainReyes self-assigned this Apr 6, 2015
EfrainReyes added a commit that referenced this issue Apr 6, 2015
@EfrainReyes
Issue #12
9b38300 
- Moved Regular Expressions to static readonly fields with compiled option.
- Made formatting changes.
EfrainReyes added a commit that referenced this issue Apr 6, 2015
@EfrainReyes
Issue #12
dde58bf 
- Added BbPinValidator class
- Made validator fields use Poor Man's DI instead of getting an instance
  directly in the private field declaration.
- Added unit tests for MSISDN attribute with user-defined prefixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EfrainReyes EfrainReyes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@EfrainReyes