Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible tweaks to the slack action #1740

Closed
bitdivine opened this issue Jul 11, 2023 · 0 comments · Fixed by #1768
Closed

Possible tweaks to the slack action #1740

bitdivine opened this issue Jul 11, 2023 · 0 comments · Fixed by #1768

Comments

@bitdivine
Copy link
Member

Thank you for showing how to make notifications with the slack action.

There are two small chnages that you might find interesting:

  • There is a typo in the description. send -> sends
  • There is a github actions variable for the repository name. If you use that, the action can be used in other projects without change. See, GITHUB_REPOSITORY as defined here: https://docs.github.com/en/actions/learn-github-actions/variables This of course has no benefit for internet identity itself, indeed it adds risk if GitHub changes the variable, but your fans would appreciate it.
$ diff action.yml  ~/dfn/internet-identity/.github/actions/slack/action.yml 
2c2
< description: 'A simple action that sends a slack message to a channel.'
---
> description: 'A simple action that send a slack message to a channel.'
14c14
<         echo '{}' | jq --arg text "$MESSAGE: https://github.com/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID" '.text = $text' | \
---
>         echo '{}' | jq --arg text "$MESSAGE: https://github.com/dfinity/internet-identity/actions/runs/$GITHUB_RUN_ID" '.text = $text' | \
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant