You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you for showing how to make notifications with the slack action.
There are two small chnages that you might find interesting:
There is a typo in the description. send -> sends
There is a github actions variable for the repository name. If you use that, the action can be used in other projects without change. See, GITHUB_REPOSITORY as defined here: https://docs.github.com/en/actions/learn-github-actions/variables This of course has no benefit for internet identity itself, indeed it adds risk if GitHub changes the variable, but your fans would appreciate it.
$ diff action.yml ~/dfn/internet-identity/.github/actions/slack/action.yml
2c2
< description: 'A simple action that sends a slack message to a channel.'
---
> description: 'A simple action that send a slack message to a channel.'
14c14
< echo '{}' | jq --arg text "$MESSAGE: https://github.com/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID" '.text = $text' | \
---
> echo '{}' | jq --arg text "$MESSAGE: https://github.com/dfinity/internet-identity/actions/runs/$GITHUB_RUN_ID" '.text = $text' | \
The text was updated successfully, but these errors were encountered:
Thank you for showing how to make notifications with the slack action.
There are two small chnages that you might find interesting:
GITHUB_REPOSITORY
as defined here: https://docs.github.com/en/actions/learn-github-actions/variables This of course has no benefit for internet identity itself, indeed it adds risk if GitHub changes the variable, but your fans would appreciate it.The text was updated successfully, but these errors were encountered: