Always display error details #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmattia
force-pushed
the
nm-error-details
branch
from
a8be96a to
d741016
Compare
Before this we'd hide error details behind a `<details>` element, but all error messages I've seen so far were very short, meaning they'd fit perfectly well on the page. These changes always show the error message, which makes error pages more consistent and avoid styling issues re. the more dynamic page.
nmattia
force-pushed
the
nm-error-details
branch
from
d741016 to
de0895f
Compare
|
The error detail could also be Also, the detail is usually technical so for most users the content might not be understandable. But I don't feel strongly about showing it by default. It might also help developers if users take screenshots of the error messages. |
frederikrothenberger
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #928
Before this we'd hide error details behind a
<details>element, but all error messages I've seen so far were very short, meaning they'd fit perfectly well on the page.These changes always show the error message, which makes error pages more consistent and avoid styling issues re. the more dynamic page.