Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C4GT] Network-Score: Add tests for 'UnauthorizedOperation' #294

Open
3 tasks
vatsa287 opened this issue Feb 5, 2024 · 7 comments · May be fixed by #552 or #557
Open
3 tasks

[C4GT] Network-Score: Add tests for 'UnauthorizedOperation' #294

vatsa287 opened this issue Feb 5, 2024 · 7 comments · May be fixed by #552 or #557
Assignees
@Vaibhavsahu2810
Labels
C4GT Community good first issue Good for newcomers

Comments

@vatsa287
Copy link
Member

vatsa287 commented Feb 5, 2024

Description

Subtask under : cord-network/community#7

New testcase can be tested under cargo test -p pallet-network-score after adding it in the code.

Goals

  • Add tests for UnauthorizedOperation for pallet/network-score

Expected Outcome

  • Test should assert for UnauthorizedOperation being returned properly in all the possible calls.
  • If there are more than one function returning this error code, all of them should be validated either as one test case or as multiple test cases.

Acceptance Criteria

NA

Implementation Details

Look at other test cases, and add a test case for the same.
Ex: In pallets/network-membership check method test_duplicate_member_request which validates error code MembershipAlreadyAcquired

Mockups / Wireframes

NA

Product Name

CORD

Organization Name

Dhiway

Domain

Blockchain

Tech Skills Needed

Rust

Mentor(s)

@amarts

Complexity

[Low]

Category

[Test]

Sub Category

[Beginner friendly]
@amarts amarts added the good first issue Good for newcomers label Feb 6, 2024
@hardik-pratap-singh
Copy link
Contributor

Hey @amarts
I would like to work on this issue !
Kindly assign it to me if possible.

@vatsa287
Copy link
Member Author

vatsa287 commented Apr 2, 2024

@hardik-pratap-singh Look at this issue.

@hardik-pratap-singh hardik-pratap-singh mentioned this issue Apr 3, 2024
Closed
3 tasks
@ayush572
Copy link

ayush572 commented Aug 6, 2024

Hey @amarts! I'm looking forward to contribute towards solving this issue. Could you please assign it to me? I already have experience with Rust and Blockchain and I believe I can deliver the same to the community in no time! Looking forward for a positive response from your end.

@VedantKhairnar
Copy link

Hello @ayush572
Do you need any assistance with the issue or any progress you might want to share?
Thanks.

@Vaibhavsahu2810
Copy link
Contributor

Vaibhavsahu2810 commented Dec 25, 2024 •
edited
Loading

Hello,@vatsa287 should i work on it

Vaibhavsahu2810 added a commit to Vaibhavsahu2810/cord that referenced this issue Dec 28, 2024
@Vaibhavsahu2810
Fixes: dhiway#294 Add test cases for UnauthorizedOperation error
8a5aaa4 
Signed-off-by: Vaibhav <[email protected]>
@Vaibhavsahu2810 Vaibhavsahu2810 linked a pull request Dec 28, 2024 that will close this issue
Open
@HasanZaigam
Copy link

please assign me this issue @vatsa287

@HasanZaigam
Copy link

I have made changes and tried to add the desired test case, and here is the PR - #557

@vatsa287 Bro, please go through it and let me know what changes need to be made to fix the test and help me tackle this issue successfully. I need your help with this.....

@vatsa287 vatsa287 linked a pull request Jan 3, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vaibhavsahu2810 Vaibhavsahu2810

Labels
C4GT Community good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
7 participants
@amarts @VedantKhairnar @vatsa287 @ayush572 @hardik-pratap-singh @HasanZaigam @Vaibhavsahu2810