Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issue in /dlflow/models/internal (by P3) #9

Open
DLPerf opened this issue Aug 30, 2021 · 2 comments
Open

Performance issue in /dlflow/models/internal (by P3) #9

DLPerf opened this issue Aug 30, 2021 · 2 comments

Comments

@DLPerf
Copy link

DLPerf commented Aug 30, 2021

Hello! I've found a performance issue in /NNDenseInput.py: .batch(batch_size=config.MODEL.batch_size,drop_remainder=config.MODEL.drop_remainder)(here) should be called before .map(map_func=_parse_single_example,num_parallel_calls=parallel)(here), which could make your program more efficient.

Here is the tensorflow document to support it.

Besides, you need to check the function _parse_single_example called in .map(map_func=_parse_single_example,num_parallel_calls=parallel) whether to be affected or not to make the changed code work properly. For example, if _parse_single_example needs data with shape (x, y, z) as its input before fix, it would require data with shape (batch_size, x, y, z) after fix.

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

@DLPerf
Copy link
Author

DLPerf commented Nov 4, 2021

Hello, I'm looking forward to your reply~

@HCMY
Copy link
Contributor

HCMY commented Mar 15, 2022

Hello, I'm looking forward to your reply~

the author is busily dating with someone, try make a PR to push him

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants