Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch http client to gopkg.in/h2non/gentleman.v1 #31

Open
hnakamur opened this issue Jul 23, 2016 · 1 comment
Open

Switch http client to gopkg.in/h2non/gentleman.v1 #31

hnakamur opened this issue Jul 23, 2016 · 1 comment

Comments

@hnakamur
Copy link

After the discussion at #28 (comment), I'm trying to implement sending http requests with gopkg.in/h2non/gentleman.v1.

Currently I successfully get the version in Connect and log requests and responses.
v2...hnakamur:96ec36d14ec6dfb1be21c6f74607fb84f9147ff2

Could you tell me what do you think?
If it's ok, I'll continue to switch all occurrences of sending requests to gopkg.in/h2non/gentleman.v1.
@hnakamur
Copy link
Author

I'm inclined to write wrapper for gentleman to have the same methods as github.com/diegogub/napping.
I think it's easier than replacing all occurrences of sending requests.

@hnakamur hnakamur mentioned this issue Jul 24, 2016
Merged
@diegogub diegogub closed this as completed Sep 7, 2016
@diegogub diegogub reopened this Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hnakamur @diegogub