Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NsEnhancedDeckUx bugs & features #5

Open
13 tasks
dithpri opened this issue Feb 1, 2023 · 0 comments
Open
13 tasks

NsEnhancedDeckUx bugs & features #5

dithpri opened this issue Feb 1, 2023 · 0 comments

Comments

@dithpri
Copy link
Owner

dithpri commented Feb 1, 2023 •
edited
Loading

Bugs:

  • Buttons duplicate when expression is changed
  • Should be disabled on card pages & show_market=decks
  • asHtmlDataSetKey doesn't convert apostrophes/other invalid chars: script errors out on "nation's bids" page
    • Suggestion: treat that page's "nation's bids/asks/etc." columns as a special case
  • Expression input breaks when pressing a keybind (I should've seen that coming!)
    • Suggestion: use Mousetrap instead

Features:

  • Update DV/Bank on junk
  • Add default_flag/game_flag boolean for use in expressions
  • Add puppet value for use in expressions (body.dataset.nname)
  • Use Mousetrap to not go crazy handling keybinds
  • Switch to last page of deck first when using keybinds, go to previous page when processing is complete
  • Close tab after finishing processing
  • Highlight mismatched ask/bid (or just highlight the Match column)
  • Sort when clicking on a column header

Misc:

  • Extract part of the filtering function to the Row class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dithpri