Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo: CI error for poetry.lock file #597

Open
zilto opened this issue Jan 29, 2025 · 0 comments
Open

repo: CI error for poetry.lock file #597

zilto opened this issue Jan 29, 2025 · 0 comments

Comments

@zilto
Copy link
Collaborator

zilto commented Jan 29, 2025

In #596, poetry was pinned to ==1.8.5 for both CI and Makefile to avoid breaking changes from poetry>=2.0

For instance, the venv would fail to build (see action logs)

Setting Poetry installation path as /home/runner/.local

Installing Poetry 👷

Retrieving Poetry metadata

# Welcome to Poetry!

This will download and install the latest version of Poetry,
a dependency and package manager for Python.

It will add the `poetry` command to Poetry's bin directory, located at:

/home/runner/.local/bin

You can uninstall at any time by executing this script with the --uninstall option,
and these changes will be reverted.

Installing Poetry (2.0.1)
Installing Poetry (2.0.1): Creating environment
Installing Poetry (2.0.1): Installing Poetry
Installing Poetry (2.0.1): An error occurred. Removing partial environment.
Poetry installation failed.
See /home/runner/work/verified-sources/verified-sources/poetry-installer-error-_uh4zmyy.log for error logs.

Problem

Despite the change, CI fails to build the venv and complains about the lockfile (see action logs)

Note that no cache is found on the previous step Load cached venv

Poetry (version 1.8.5)
poetry install --without unstructured_data
Creating virtualenv dlt-verified-sources in /home/runner/work/verified-sources/verified-sources/.venv
Installing dependencies from lock file
The lock file might not be compatible with the current version of Poetry.
Upgrade Poetry to ensure the lock file is read properly or, alternatively, regenerate the lock file with the `poetry lock` command.

pyproject.toml changed significantly since poetry.lock was last generated. Run `poetry lock [--no-update]` to fix the lock file.
make: *** [Makefile:25: dev] Error 1

For reference, we have a recent merged PR that uses poetry==1.8.5 and successfully retrieves a cached venv (see action logs)

Investigation

The last commit to change the poetry.lock and the pyproject.toml was #585. There's apparently no PR that were merge after these changes.

Following the error message instructions, doing poetry lock --no-update takes 7.2s and get this message

The lock file might not be compatible with the current version of Poetry.
Upgrade Poetry to ensure the lock file is read properly or, alternatively, regenerate the lock file with the `poetry lock` command.

Note

--no-update is deprecated in poetry>=2.0

Doing poetry lock took 3700s locally (1h+). It updated a lot of dependencies and I'll open a PR for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Planned
Development

No branches or pull requests

2 participants