Fetch mode hint is ignored when using Paginator

[aprat84]

Bug Report

Q	A
Version	2.20.0 / 3.3.0
Previous working version	2.19.8 / 3.2.3

Summary

This is related to issue #11128 and PR #11445.

When a fetch=EAGER association is filtered using WITH, it raises an error unless fetch mode is overridden by calling setFetchMode(LAZY) over the association.

This worked well after the fix in #11445.

Somehow, in 2.20.x and 3.3.x this bug returned, partially, only when using Paginator with fetchJoinCollection parameter set to true.

Seems like #11188 introduced this bug.

Current behavior

An exception is raised even when fetch mode is overridden.

Expected behavior

It should work the same with or without pagination.

How to reproduce

See test in https://github.com/aprat84/orm/tree/gh-11741

vendor/bin/phpunit --filter testSubselectFetchJoinWithAllowedWhenOverriddenNotEagerPaginator

There was 1 error:

1) Doctrine\Tests\ORM\Functional\EagerFetchCollectionTest::testSubselectFetchJoinWithAllowedWhenOverriddenNotEagerPaginator
Doctrine\ORM\Query\QueryException: Associations with fetch-mode=EAGER may not be using WITH conditions in "Doctrine\Tests\ORM\Functional\EagerFetchChild#owner".

[aprat84]

Seems like #11188 introduced this bug. Commits were squashed apparently, so can't test them separately.

@mpdude @greg0ire

[aprat84]

@mpdude can you take a look at while you may still have fresh memory of what you did in #11188?

This is preventing me to update to next minor...

[aprat84]

I looked into it a little bit, and I think the problem is that in LimitSubqueryOutputWalker the Query is cloned, but not the hints:

orm/src/Tools/Pagination/LimitSubqueryOutputWalker.php

Line 108 in 73e68f3

$query = clone $query;

Don't know if parameters also need to be cloned, as it is done in

orm/src/Tools/Pagination/Paginator.php

Line 183 in 73e68f3

private function cloneQuery(Query $query): Query