Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building just the sdk installers in dotnet/sdk #4777

Open
ViktorHofer opened this issue Dec 2, 2024 · 0 comments
Open

Allow building just the sdk installers in dotnet/sdk #4777

ViktorHofer opened this issue Dec 2, 2024 · 0 comments
Assignees

Comments

@ViktorHofer
Copy link
Member

When building the sdk installers in BuildPass=2 on Windows (as they depend on join assets from different verticals) the redist-installers.csproj project needs to be referenced in the repo's Build.props file. This causes the entire archive to be built again which is throw-away work and results in duplicate assets when merged and uploading everything. This is especially important as that logic will run in a BuildPass leg which means that it's on the critical path from a build time perspective.

It should be possible to encapsulate the logic that is responsible for creating the installers in dotnet/sdk and only invoke that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

2 participants