Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New wpf binaries in VMR #4831

Closed
Winniexu01 opened this issue Jan 16, 2025 · 1 comment · Fixed by dotnet/sdk#46044
Closed

New wpf binaries in VMR #4831

Winniexu01 opened this issue Jan 16, 2025 · 1 comment · Fixed by dotnet/sdk#46044
Labels
area-build Improvements in source-build's own build process ops-monitor Issues created/handled by the source build monitor role untriaged

Comments

@Winniexu01
Copy link
Member

main build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2621723&view=logs&j=fa5c2909-0e29-5671-d5eb-16d6c40e0c4a&t=2a0bd486-3f67-5c59-da0c-b84d88848a4b (internal Microsoft link)

The Scan for binaries step is getting a warning from below newly introduced binary files:

05:15:16 dbug: BinaryTool[0] New binaries:
05:15:16 dbug: BinaryTool[0]     src/wpf/src/Microsoft.DotNet.Wpf/tests/UnitTests/WindowsBase.Tests/Resources/Invalid_1.xps
05:15:16 fail: BinaryTool[0] ERROR: 1 new binaries. Check '/mnt/vss/_work/1/s/artifacts/log/binary-report/NewBinaries.txt' for details.
@Winniexu01 Winniexu01 added ops-monitor Issues created/handled by the source build monitor role untriaged labels Jan 16, 2025
@Winniexu01
Copy link
Member Author

Related to dotnet/wpf#8215. This is test binary, so it can be added to the allowed-vmr-binaries list.

@Winniexu01 Winniexu01 mentioned this issue Jan 16, 2025
Merged
@MichaelSimons MichaelSimons added the area-build Improvements in source-build's own build process label Jan 16, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in .NET Source Build Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-build Improvements in source-build's own build process ops-monitor Issues created/handled by the source build monitor role untriaged
Projects
.NET Source Build
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow wpf test binary in VMR Winniexu01/sdk
2 participants
@MichaelSimons @Winniexu01