Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues in Chrome Extension context #5

Open
multimeric opened this issue Apr 23, 2020 · 1 comment
Open

Issues in Chrome Extension context #5

multimeric opened this issue Apr 23, 2020 · 1 comment

Comments

@multimeric
Copy link
Contributor

You're currently compiling this as a UMD (which is great), however the gulp UMD seems to output this:

;(function(root, factory) {
  if (typeof define === 'function' && define.amd) {
    define([], factory);
  } else if (typeof exports === 'object') {
    module.exports = factory();
  } else {
    root.Puz = factory();
  }
}(this, function() {
// Code
}));

I suppose this works fine in the browser, since this is bound to window, but Chrome extensions don't seem to have a value for this, causing this entire module to fail to load.

Happening with [email protected].

@multimeric
Copy link
Contributor Author

I think the solution relates to this: https://stackoverflow.com/a/34983495/2148718

@multimeric multimeric mentioned this issue Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant