Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't disable cache #3

Open
dr4Ke opened this issue Nov 28, 2010 · 0 comments
Open

don't disable cache #3

dr4Ke opened this issue Nov 28, 2010 · 0 comments

Comments

@dr4Ke
Copy link
Owner

dr4Ke commented Nov 28, 2010

This will need changes in the dokuwiki core code. I sent an email on the dokuwiki mailing list containing :

II. ISSUE

The cache feature of dokuwiki stores a preparsed version of the page.
As I didn't find a way to store all values in this page, the edit
buttons are inconsistent when using cache.
The issue is that I can't change the way the edit sections values are
stored in the cache. Then, for now, I disable it completely for my
plugin to really work as expected.

I can't think of a way to do what I want without, either :
. disabling cache
. catch the event RENDERER_CONTENT_POSTPROCESS and rewrite comments with useful values
. change dokuwiki code

The first two options are bad as they introduce more processing each
time the page is viewed. The third can be done in two ways :
o implement two new events that could modify the way startSectionEdit
and finishSectionEdit works. The editsections plugin will use these
hooks to rewrite useful values before storing the page in cache.
o implement a standard option into dokuwiki to choose section editing behavior :
. one section, edit button at end of section (current behavior)
. one section, edit button at the beginning of each section
. nested sections, edit button at the beginning of each section

III. QUESTIONS

Is there a way to implement this plugin without touching dokuwiki core ?

If not, which way would be better : new hooks or implementing section
editing behavior in the core ? I can provide patches for one or both
ways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant