Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert old functions to be pure #3

Open
MikeCarbone opened this issue Mar 10, 2020 · 0 comments
Open

Convert old functions to be pure #3

MikeCarbone opened this issue Mar 10, 2020 · 0 comments

Comments

@MikeCarbone
Copy link
Member

Remove added logic from functions. Like in group service, ensuringGroupOwner fetches the user, but other functions should supply that. Maybe consider classifying functions as low-level, entry point, etc. to determine where DB calls should be made like this. Separate out pure functions and such. Make sure each operation hits the DB as little as possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant