Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method to close the custom tab? #17

Open
hiddencaliber opened this issue Apr 24, 2019 · 11 comments
Open

Method to close the custom tab? #17

hiddencaliber opened this issue Apr 24, 2019 · 11 comments

Comments

@hiddencaliber
Copy link

No description provided.

@ashkryab
Copy link

me to

@ashkryab
Copy link

need close tab after hendle deep link

@agarzas
Copy link

agarzas commented Oct 17, 2019

@ashkryab @hiddencaliber did you find a solution to this issue?

@yokristiawan-gmail-com
Copy link

If the website is yours, you can use JavaScript window.close() command to close the browser.

@daniellampl
Copy link
Contributor

I agree with @ashkryab. After deep linking into the app from a custom tab, the previous custom tab seems to still open in the background. This results in the behavior, that no other custom tab can get opened while the app is running.

@droibit is it possible to close previously opened custom tabs?

@droibit
Copy link
Owner

droibit commented Jun 22, 2021

@daniellampl
Please consider url_lancher to open a deep link URL,
as I can not provide a good solution from this plugin for now.

I understand that flutter_custom_tabs and deep links are incompatible,
so I'll consider a fundamental solution.

@ayechan-maung
Copy link

@daniellampl Please consider url_lancher to open a deep link URL, as I can not provide a good solution from this plugin for now.

I understand that flutter_custom_tabs and deep links are incompatible, so I'll consider a fundamental solution.

deep links work for Android but not for iOS.

@danwild
Copy link

danwild commented Apr 22, 2024

Dupe of #33 ?

Nice work on this plugin @droibit , thanks 👍

But also, this is a critical issue.

Are there any plans to merge in something like the functionality mentioned previously?

Or something similar to closeInAppWebView?

@Suman085
Copy link

Same here..
I'd want to get the url in return once we hit a deep/app link url and also close the tab automatically..

Awesome plugin though!!

@danwild
Copy link

danwild commented Apr 26, 2024

There is an existing method to do this! And it is in the docs.

Apologies for the oversight 😅

Just call closeCustomTabs.

Thanks @droibit 🎉

This kinda addresses #33 too

@droibit
Copy link
Owner

droibit commented Apr 28, 2024

Hi,

Thank you for your comments and insights. As you mentioned,
flutter_custom_tabs currently offers the closeCustomTabs function to manually close Custom Tabs.

I'm glad to hear that this function may match your use case. If you are considering using OAuth,
you may want to explore plugins like flutter_web_auth_2 for a better user experience as it leverages OS capabilities.

For now, there are no immediate plans to add additional functionality beyond manually closing Custom Tabs.
However, I recognize that closing Custom Tabs is a key use case for OAuth,
and I will begin considering support for OAuth authentication in future versions of the plugin.

Thank you for your feedback and suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants