Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify thickness (and other properties?) between layers and structures. #117

Open
EmCeBeh opened this issue Apr 14, 2023 · 1 comment
Open

Comments

@EmCeBeh
Copy link
Contributor

EmCeBeh commented Apr 14, 2023

It might be useful to get the thicknesses a structures, not knowing weather it is a layers or again a structure.

However, this is not as trivial as:

  • layers have the attribute thickness, and NO function get_thickness()
  • structures have NO attribute thickness, but the function get_thickness()

Is this intended?
Can it be generalised, such that "any" object, which has a thickness has the same way of accessing it?

Maybe this might be usefull for other properties, too?

Thanks

Martin & @S0nn1ck

@dschick
Copy link
Owner

dschick commented Apr 14, 2023

indeed one could unify it for common properties. Could you list all of them, which come into your mind?
thickness, mass are straightforward. Other ones need to be averaged and might not be too useful anyway.

I welcome any pull request for this improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants