Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Rarity ordering broken #32

Open
qqkookie opened this issue Nov 21, 2022 · 0 comments
Open

The Rarity ordering broken #32

qqkookie opened this issue Nov 21, 2022 · 0 comments

Comments

@qqkookie
Copy link

qqkookie commented Nov 21, 2022

The rarity condition statement does not works as many people expects.

The Rarity ordering of d2lootfilter is | Rarity <Rarity> | Inferior, Normal, Superior, Magic, Set, Rare, Unique, Crafted | as documented and works as documented. Rare is between Set and Unique.
But it is different from what many user perceives generally. Ordering should be "Inferior, Normal, Superior, Magic, Rare, Set, Unique, Crafted". i.e, order of Rare and Set should be switched. Internal numerical ordering does not matter. This causes some unexpected behavior of filter and confuse user.
Condition Rarity < Rare should not include Set and Rarity in Rare-Unique should include Set.

And the documentation of Rarity condition is not clear. It says "Rarity <Rarity>" excluding <Opeartor>. It should be Rarity [<Operator>] <Rarity>, I guess.

And second problem is that Rarity of unidentified items in gambling vendor is always evaluated as "Inferior". Rarity of ordinary sales item of vendor is evaluated correctly, but Rarity of Gambling item of same vendor is evaluated incorrectly as Inferior. Other unidentified items in inventory is evaluated correctly as Magic or Rare. If this is game feature to prevents gambling cheat, there must be way to discern true Inferior item and Gambling item. My suggestion is re-map item rarity index to Inferior =0 , Normal =1 , Superior =2 , Magic = 3 , Set =4 , Rare = 5, Unique = 6, Crafted = 7 Gambling = 8, to fix order of Set and Rare .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant