From d9e44256666b97bcaa46ef5a6bb3821342f1371d Mon Sep 17 00:00:00 2001
From: Anas DORBANI <95044293+dorbanianas@users.noreply.github.com>
Date: Sat, 7 Dec 2024 01:32:46 +0100
Subject: [PATCH] fix secret queries (#87)

---
 docs/docs/faq.mdx                             |  3 ---
 .../resource-management/secret-management.md  | 20 +++++++++----------
 docs/docs/supported-providers/azure.md        |  6 +++---
 docs/docs/supported-providers/ollama.md       |  2 +-
 docs/docs/supported-providers/openai.md       |  2 +-
 5 files changed, 15 insertions(+), 18 deletions(-)

diff --git a/docs/docs/faq.mdx b/docs/docs/faq.mdx
index 506f1059..57a1d43d 100644
--- a/docs/docs/faq.mdx
+++ b/docs/docs/faq.mdx
@@ -76,9 +76,6 @@ Refer to the [Model Management](/docs/resource-management/model-management) sect
 </Collapse>
 
 <Collapse title="How do I set up secrets for providers?">
-Secrets are configured using commands like:
-- `CREATE SECRET OPENAI="d-key-goes-here";`
-- `UPDATE SECRET AZURE="d-key-goes-here";`
 Check the [Secrets Management](/docs/resource-management/secret-management) section for a step-by-step guide.
 </Collapse>
 
diff --git a/docs/docs/resource-management/secret-management.md b/docs/docs/resource-management/secret-management.md
index f0140f29..bbd4c787 100644
--- a/docs/docs/resource-management/secret-management.md
+++ b/docs/docs/resource-management/secret-management.md
@@ -23,7 +23,7 @@ Secrets can be created with the `CREATE SECRET` SQL command. Temporary secrets a
 
 ```sql
 CREATE SECRET (
-    TYPE OPENAI
+    TYPE OPENAI,
     API_KEY 'your-api-key'
 );
 ```
@@ -34,7 +34,7 @@ This creates a secret named `__default_openai`.
 
 ```sql
 CREATE SECRET (
-    TYPE OLLAMA
+    TYPE OLLAMA,
     API_URL '127.0.0.1:11434'
 );
 ```
@@ -45,9 +45,9 @@ This creates a secret named `__default_ollama`.
 
 ```sql
 CREATE SECRET (
-    TYPE AZURE
-    API_KEY 'your-key-here'
-    RESOURCE_NAME 'resource-name'
+    TYPE AZURE,
+    API_KEY 'your-key-here',
+    RESOURCE_NAME 'resource-name',
     API_VERSION 'api-version'
 );
 ```
@@ -62,7 +62,7 @@ To persist secrets across DuckDB sessions, use `CREATE PERSISTENT SECRET`:
 
 ```sql
 CREATE PERSISTENT SECRET (
-    TYPE OPENAI
+    TYPE OPENAI,
     API_KEY 'your-api-key'
 );
 ```
@@ -71,7 +71,7 @@ CREATE PERSISTENT SECRET (
 
 ```sql
 CREATE PERSISTENT SECRET (
-    TYPE OLLAMA
+    TYPE OLLAMA,
     API_URL '127.0.0.1:11434'
 );
 ```
@@ -80,9 +80,9 @@ CREATE PERSISTENT SECRET (
 
 ```sql
 CREATE PERSISTENT SECRET (
-    TYPE AZURE
-    API_KEY 'your-key-here'
-    RESOURCE_NAME 'resource-name'
+    TYPE AZURE,
+    API_KEY 'your-key-here',
+    RESOURCE_NAME 'resource-name',
     API_VERSION 'api-version'
 );
 ```
diff --git a/docs/docs/supported-providers/azure.md b/docs/docs/supported-providers/azure.md
index 29a338ca..35eb760f 100644
--- a/docs/docs/supported-providers/azure.md
+++ b/docs/docs/supported-providers/azure.md
@@ -11,9 +11,9 @@ To use the Azure API, configure it using the secret manager. Use the following q
 
 ```sql
 CREATE SECRET (
-    TYPE AZURE
-    API_KEY 'your-key-here'
-    RESOURCE_NAME 'resource-name'
+    TYPE AZURE,
+    API_KEY 'your-key-here',
+    RESOURCE_NAME 'resource-name',
     API_VERSION 'api-version'
 );
 ```
diff --git a/docs/docs/supported-providers/ollama.md b/docs/docs/supported-providers/ollama.md
index 915bd816..62ee9848 100644
--- a/docs/docs/supported-providers/ollama.md
+++ b/docs/docs/supported-providers/ollama.md
@@ -18,7 +18,7 @@ Specify the Ollama URL using the DuckDB secret manager. Use the following query:
 
 ```sql
 CREATE SECRET (
-    TYPE OLLAMA
+    TYPE OLLAMA,
     API_URL '127.0.0.1:11434'
 );
 ```
diff --git a/docs/docs/supported-providers/openai.md b/docs/docs/supported-providers/openai.md
index 18060e96..6010c04f 100644
--- a/docs/docs/supported-providers/openai.md
+++ b/docs/docs/supported-providers/openai.md
@@ -11,7 +11,7 @@ Configure your OpenAI API key securely using the DuckDB secret manager with this
 
 ```sql
 CREATE SECRET (
-    TYPE OPENAI
+    TYPE OPENAI,
     API_KEY 'your-api-key'
 );
 ```