-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues with the GOSPA metric #999
Comments
I think issue 2. was fixed in #967 |
@sdhiscocks Thanks for pointing out that! I was not aware, I found that issue some time ago and I forgot about mentioning before. Glad it is fixed now |
If we want a common visualisation process that is agnostic to whether we use GOSPA or OSPA, I think there is still an issue here. Do we want the OSPA output to look like GOSPA's or vice versa? I don't think we want to persist the current status quo |
To get any visualisation, I 'hacked' Stone-Soup/stonesoup/metricgenerator/ospametric.py Lines 192 to 196 in 13f7578
This way I only access 'distance' metric, which then can be visualised. By replacing 'distance' with 'localisation', 'missed', or 'false', it is (potentially) possible to get access to other information that is particular to GOSPA. P.S. Visualisation of the GOSPA metric is accessed via |
I ran into a couple of problems trying to use GOSPA in place of the OSPA metric:
compute_OSPA_distance
returns a scalar,compute_gospa_metric
is designed to return a dictionary of values (including that of distance). This leads to problems with visualising the GOSPA errors using built-in tools, as scalar values are anticipated.from stonesoup.metricgenerator.ospametric import GOSPAMetric as OSPAMetric
) as it leads to issues when trying to extract a timestamp from a numpy array of Particle elements.Perhaps, some of these issues are known (at least I heard about the second one from @A-acuto), but I couldn't find them explicitly outlined here.
The text was updated successfully, but these errors were encountered: