From 08ca7ad974497b271422fd0b6b644c6bc387388f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?K=C3=A9vin=20Dunglas?= <kevin@dunglas.fr>
Date: Wed, 15 Nov 2023 16:41:44 +0100
Subject: [PATCH] ci: disable tests with 8.3 shared library

---
 .github/workflows/tests.yml |  4 +++-
 CONTRIBUTING.md             | 26 +++++++++++++-------------
 2 files changed, 16 insertions(+), 14 deletions(-)

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index 7b517409f5..5233976b75 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -12,7 +12,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        php-versions: ['8.2', '8.3']
+        php-versions: ['8.2'] # 8.3 is disabled because of https://github.com/shivammathur/setup-php/issues/783
     steps:
       -
         uses: actions/checkout@v4
@@ -30,8 +30,10 @@ jobs:
           ini-file: development
           coverage: none
           tools: none
+          extensions: none, opcache
         env:
           phpts: ts
+          debug: true
       -
         name: Set CGO flags
         run: |
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 67380a001a..a9851e786f 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -99,31 +99,31 @@ docker buildx bake -f docker-bake.hcl --pull --no-cache --push
     ```
 3. Enable `tmate` to connect to the container
     ```patch
-        - name: Set include flags
+        -
+          name: Set CGO flags
           run: echo "CGO_CFLAGS=$(php-config --includes)" >> "$GITHUB_ENV"
-    +   - run: |
-            sudo apt install gdb
+    +   -
+    +     run: |
+    +       sudo apt install gdb
     +       mkdir -p /home/runner/.config/gdb/
     +       printf "set auto-load safe-path /\nhandle SIG34 nostop noprint pass" > /home/runner/.config/gdb/gdbinit
-    +   - uses: mxschmitt/action-tmate@v3
-    +     env:
-    +       GOFLAGS: "-w -gcflags=all=-N -gcflags=all=-l"
+    +   -
+    +     uses: mxschmitt/action-tmate@v3
     ```
-4. Open `frankenphp.go`
-5. Enable `cgosymbolizer`
+4. Connect to the container
+5. Open `frankenphp.go`
+6. Enable `cgosymbolizer`
     ```patch
     -	//_ "github.com/ianlancetaylor/cgosymbolizer"
     +	_ "github.com/ianlancetaylor/cgosymbolizer"
     ```
-6. Download the module: `go get`
-7. In the container, you can use GDB and the like:
+7. Download the module: `go get`
+8. In the container, you can use GDB and the like:
     ```sh
-    sudo apt install gdb
-    mkdir -p /home/runner/.config/gdb/
     go test -c -ldflags=-w
     gdb --args ./frankenphp.test -test.run ^MyTest$
     ```
-8. When the bug is fixed, revert all these changes
+9. When the bug is fixed, revert all these changes
 
 ## Misc Dev Resources