#15 Added Typescript to the project #22

Fedeorlandau · 2021-10-12T12:37:08Z

Hi there, I rewrote this in typescript and removed babel. Closes #15

Please let me know if this works for you. Tests are working fine.

Regards :)

shtyr-maxim · 2022-02-17T10:31:11Z

src/index.ts

+    this.sizes = sizes;
+  }
+
+  _isBreakpoint(breakpoint: string) {


this method is private

you should describe return types for methods

shtyr-maxim · 2022-02-17T10:45:24Z

src/index.ts

+    }
+
+    return `@media (min-width: ${this.sizes[min]}px) and
+			(max-width: ${this.sizes[max] - 0.02}px)`;


something wrong with tabs

shtyr-maxim · 2022-02-17T10:46:52Z

tsconfig.json

+        "node_modules",
+        "dist"
+    ]
+}


you should add final newline

shtyr-maxim · 2022-02-17T10:47:05Z

.eslintrc

+	  "plugin:@typescript-eslint/eslint-recommended",
+	  "plugin:@typescript-eslint/recommended"
+	]
+  }


final newline

Rewrote it in typescript

390952e

Fedeorlandau changed the title ~~Rewrote it in Typescript~~ #15 Added Typescript to the project Oct 12, 2021

shtyr-maxim reviewed Feb 17, 2022

View reviewed changes

Provide feedback