Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for composer tag #409

Closed
s-fleck opened this issue Jun 26, 2024 · 10 comments · Fixed by #426
Closed

Support for composer tag #409

s-fleck opened this issue Jun 26, 2024 · 10 comments · Fixed by #426
Assignees
Labels
enhancement New feature or request OpenSubsonic
Milestone

Comments

@s-fleck
Copy link

s-fleck commented Jun 26, 2024

While composer (and possibly performer) tags are really obscure in most genres of music, they are pretty essential to keep a classical music collection organized IMHO. Support for these is lackluster, but as far as i could find the opensubsonic API spec includes it (see links below)

https://opensubsonic.netlify.app/docs/responses/child/
https://opensubsonic.netlify.app/docs/responses/artistid3/

I've been trying to get around this using the Album Artist and Artist tags, but it's getting pretty confusing and doesn't work all that well :(. I'm also not sure how many server support that tag, probably not yet a lot, but it has to start somewhere (i also submitted a similar feature request to my favourite airsonic server gonic)

@dweymouth dweymouth added OpenSubsonic enhancement New feature or request labels Jun 26, 2024
@alessandrococco
Copy link
Contributor

alessandrococco commented Jul 2, 2024

I'm also not sure how many server support that tag

LMS supports composer and performer tags:

image

(I use LMS via Supersonic)

@s-fleck
Copy link
Author

s-fleck commented Jul 2, 2024

Oh so you are saying supersonic already supports the tag (also for searching?). in that case i can close that issue again i guess.

@dweymouth
Copy link
Owner

Supersonic doesn't support the composer tag yet - and I'm not sure the OpenSubsonic APIs are rich enough yet to do anything but add it as a tracklist column. @alessandrococco if you search for a composer who is not tagged as [Album]Artist in any tracks but only composer, does it show up as an "Artist" in Supersonic? If so, maybe I can work with the APIs as they are; if not then there's nothing I can do right now other than make Composer a non-hyperlink tracklist column

@alessandrococco
Copy link
Contributor

alessandrococco commented Jul 3, 2024

The getArtists response contains info about roles:

image

image

image

(ignore the wrong album count, it's a LMS bug - fixed but unreleased)

if you search for a composer who is not tagged as [Album]Artist in any tracks but only composer, does it show up as an "Artist" in Supersonic?

Yes! I added a composer to an album (image) and it appears in the artists view:

image

but it does not appear in the album view (I added PIPPO as a composer for all tracks in this album):

image

@dweymouth
Copy link
Owner

@alessandrococco what does the "artist" page for the PIPPO "artist" look like in this case? I see that Supersonic shows it as "11 albums" - I wonder if LMS is reporting each track as an album for composers?

@alessandrococco
Copy link
Contributor

@alessandrococco what does the "artist" page for the PIPPO "artist" look like in this case?

Like a normal artist page:

image

I see that Supersonic shows it as "11 albums" - I wonder if LMS is reporting each track as an album for composers?

It was a LMS bug, now it has been fixed

image

@dweymouth dweymouth self-assigned this Jul 11, 2024
@dweymouth dweymouth added this to the 0.13.0 milestone Jul 14, 2024
@dweymouth dweymouth linked a pull request Jul 19, 2024 that will close this issue
@dweymouth
Copy link
Owner

dweymouth commented Jul 19, 2024

@alessandrococco if you get a chance, would you be able to test one of the Github Actions builds from the composer PR https://github.com/dweymouth/supersonic/actions (or built from source on the feature/composer branch)? LMS is the only server that supports composer currently and I don't have an LMS instance at the moment. But as long as LMS follows the OpenSubsonic spec, the implementation should work...

@dweymouth
Copy link
Owner

Tested and working against the LMS demo server, merged for next release!

@s-fleck
Copy link
Author

s-fleck commented Jul 21, 2024

many thanks for the quick implementation!

@alessandrococco
Copy link
Contributor

@alessandrococco if you get a chance, would you be able to test one of the Github Actions builds from the composer PR https://github.com/dweymouth/supersonic/actions (or built from source on the feature/composer branch)?

Sorry, I was busy with my family over the weekend 😅

Tested and working against the LMS demo server, merged for next release!

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request OpenSubsonic
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants