Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Lumen without Facades? #132

Open
jonaholsson opened this issue Jun 6, 2015 · 2 comments
Open

Support for Lumen without Facades? #132

jonaholsson opened this issue Jun 6, 2015 · 2 comments

Comments

@jonaholsson
Copy link

Any plans to support Lumen with $app->withFacades(); disabled in /bootstrap/app.php and referencing the libraries manually (e.g. Input and Validator)?

@dwightwatson
Copy link
Owner

Yeah, wondering what the best approach to access those services would be then. The facades are currently used in the tests. I suppose one approach would be to use app('Illuminate\Validation\Factory') and app('Illuminate\Http\Request') but not sure how I would update the tests for that.

Happy for any other suggestions or PRs, I'd like to see Lumen support sans-Facades if possible.

@jonaholsson
Copy link
Author

I'll take a look and see what can be done, but won't have time until end of next week I'm afraid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants