Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation #23

Closed
Danwhy opened this issue Nov 6, 2018 · 2 comments
Closed

Initial implementation #23

Danwhy opened this issue Nov 6, 2018 · 2 comments
Assignees
Labels
question A question needs to be answered before progress can be made on this issue starter A beginner-friendly issue that is a good starting point for a new person

Comments

@Danwhy
Copy link
Member

Danwhy commented Nov 6, 2018

Our initial requirements for this module:

  • Create an auth table/schema that is linked to a users table in the calling app. This means that we have some schema fields that we will define (username/email, password) but allows the developer using the module to define the fields that want their users to have. We'll need to make sure this works both with and without Append Only data.

  • Signup functions - endpoints or controller functions that create both the user and auth table. This will need to use the relevant auth/user changeset functions for casting/verifying passwords etc.

  • Encryption (see https://github.com/dwyl/phoenix-ecto-encryption-example) - encrypting user data for GDPR compliance.

  • Auth plug - a plug (or multiple plugs) that will allow us to authorise users and check permissions (eg. Admin permissions, edit permissions)

@nelsonic Does this sound like we're thinking along the right lines? Anything you think we should also think about to begin with?

@Danwhy Danwhy added question A question needs to be answered before progress can be made on this issue starter A beginner-friendly issue that is a good starting point for a new person labels Nov 6, 2018
@nelsonic
Copy link
Member

@Danwhy please see: #32 (thanks!)

@nelsonic
Copy link
Member

nelsonic commented May 1, 2020

All functionality described above is included in #43
The auth_plug was created as a separate reuseable package: https://github.com/dwyl/auth_plug

Thanks again for opening this issue @Danwhy 🙌

@nelsonic nelsonic closed this as completed May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question A question needs to be answered before progress can be made on this issue starter A beginner-friendly issue that is a good starting point for a new person
Projects
None yet
Development

No branches or pull requests

2 participants