Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclusion does not work #287

Open
demian-da opened this issue Feb 7, 2020 · 2 comments
Open

Exclusion does not work #287

demian-da opened this issue Feb 7, 2020 · 2 comments
Assignees
@dyatko
Labels
bug Something isn't working

Comments

@demian-da
Copy link

Exclude does not work

To Reproduce

  1. os: ubuntu
  2. markit version: 1.6.2 command: npx arkit -o arkit.svg --exclude *test*
  3. no config file
  4. clone this https://github.com/rohanjr/create-daml-app
@demian-da demian-da added the bug Something isn't working label Feb 7, 2020
@ibarapascal
Copy link

ibarapascal commented Apr 5, 2020 •
edited
Loading

Exclude the whole folder seems work.

npx arkit -d src/components -e src/components/common

For a single file seems work too.

npx arkit -d src/components -e src/components/index.tsx
npx arkit -d src/components -e src/components/PLTop/PLTop-view.tsx

But for some files seems not

npx arkit -d src/components -e src/**/*-view.tsx

Console not match as well

  "excludePatterns": [
    "..\\**\\*-view.tsx"
  ],

image

@gabe-harris-public
Copy link

Still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dyatko dyatko

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ibarapascal @dyatko @demian-da @gabe-harris-public