-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generalizing code #199
Comments
This problem should be tackled with the numba development (cf. dev_numba branch or PR #335 or Issue #242 ). What I suggest there is:
Of course this means that we have to take care of a very general behavior for all types of branches, but we actually do that already and still go through all components individually instead of performing this step just once. |
The dev_numba branch is merged. The only feature we still miss somehow is a possibility to tell the global result extraction function which results to extract. Currently, this is somewhat hard coded and the components can decide whether they need these results and could extract further results for their own, but maybe there is a smarter way to do this. |
The remaining problem already has an issue #374 . |
To generalize calculate derivatives and extract results on branch_models.py level might lead to problems in near future, as a most abstract class defines really real and concrete functions/classmethods. Therefore, there should be a discussion on how to make the code as abstract as possible, prevent duplicated code and seperate it from really concrete functions which should only be part of the real component models.
The text was updated successfully, but these errors were encountered: