You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the PumpStdType class, regression parameters are identified to calculate a pressure lift from a volume flow. In general, the degree is adaptable. In the compressor component, the following code is executed:
This does not make use of vectorization and can thus be quite slow. Another downside of the current approach is that there are objects in the std_types dictionary of every net, making it hard for the user to understand how this even works.
At the moment, all pump std_types are using polynomial approximations of degree 2. Is that normal? Is there a large variety in the curves, so that we need to make different polynomials available to the user? Or could we just simplify this aspect?
If different degrees need to be available, I would like to throw in the following suggestion:
Create different pump std_types of different degrees, either separated (e.g. pump_2d, pump_3d etc.) or all in one table including lists for the parameters.
Use a vectorized version of the current approach. If this only works with an array of fixed size, we can identify the largest degree in the beginning and hand over filled up lines to the vectorized function, which is not a problem, if we multiply with 0.
The text was updated successfully, but these errors were encountered:
In the PumpStdType class, regression parameters are identified to calculate a pressure lift from a volume flow. In general, the degree is adaptable. In the compressor component, the following code is executed:
This does not make use of vectorization and can thus be quite slow. Another downside of the current approach is that there are objects in the std_types dictionary of every net, making it hard for the user to understand how this even works.
At the moment, all pump std_types are using polynomial approximations of degree 2. Is that normal? Is there a large variety in the curves, so that we need to make different polynomials available to the user? Or could we just simplify this aspect?
If different degrees need to be available, I would like to throw in the following suggestion:
The text was updated successfully, but these errors were encountered: