Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes in std_types #343

Open
dlohmeier opened this issue Feb 1, 2022 · 1 comment
Open

Changes in std_types #343

dlohmeier opened this issue Feb 1, 2022 · 1 comment

Comments

@dlohmeier
Copy link
Collaborator

dlohmeier commented Feb 1, 2022 •
edited
Loading

I would like to discuss some necessary changes to the std type library in pandapipes, as we will further rely on a good functionality here. My suggestions are:

  1. Adapt pipe std type entries to exactly match the entries required in the pipe table.
  2. Remove the PumpStdType class and only store entries for the polynomial function of the pressure lift - volume flow ratio (e.g. in a dict). This could be transformed to a numpy array in order to performantly calculate the pressure lift for all pumps. An auxiliary function can create an interpolating function for given fix points.
@jkisse
Copy link
Collaborator

jkisse commented Jan 4, 2023

Does PR #398 cover point 2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dlohmeier @jkisse