Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separated hydraulic and heat calculation causes unexpected behavior #384

Open
SimonRubenDrauz opened this issue Jul 11, 2022 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@SimonRubenDrauz
Copy link
Collaborator

feature request
Currently, conducting a heat calculation, a hydraulic calculation is done beforehand. This calculation is done independently from the heat calculation. This can cause unexpected behaviour.

possible solutions
A solution is to couple the heat and hydraulic calcuation. Setting a flag would enable to choose between different options. I see three options:

  1. ) Seperated: Keep it like this. heat and hydraulic calcuations are seperated.
  2. ) Iterative: The results of the heat calculation are passed back to the hydraulic calculation and the entire calculation is repeated.
  3. ) Integrative: heat and hydraulic calculation are done combined.

alternatives
Keep it like this, however, adapt the documentation, so that a user understand the corresponding behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant