Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance: ReferenceBinding.superInterfaces() with redundant super interfaces #3601

Open
jukzi opened this issue Jan 23, 2025 · 0 comments

Comments

@jukzi
Copy link
Contributor

jukzi commented Jan 23, 2025

for example
org.eclipse.jdt.internal.compiler.lookup.BinaryTypeBinding.superInterfaces() recursively calls ReferenceBinding.superInterfaces() (without even using the returned type (// make super-type resolving recursive for propagating typeBits downwards) and does not protect against redundant super interfaces
sampling data from #3387 (comment):
Image
@fedejeanne you may want to protect this against already visited types too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant