[quickfix] Selecting multiple warnings with the same quickfix shows "The selected components do not have a common applicable quick fix"

[jubax]

If you have a class

public class CanBeDeclaredAsStatic {
    
    public void test() {
	String x = "foo";
	String y = toUpper(x);
	String z = toLower(y);
	System.err.println(z);
    }

    
    public String toUpper(String string) {
	return string.toUpperCase(Locale.ROOT);
    }
    
    public String toLower(String string) {
	return string.toLowerCase(Locale.ROOT);
    }
    
}

and activated the corresponding warnings you see

When you choose one of those two warnings you get a quickfix dialog which allows you to fix the problem:

But when you choose both warnings then you get "The selected components do not have a common applicable quick fix":

I would have expected that the UI allows me to get both warnings fixed at the same time because they both have the same quick fix.

[jukzi]

I dislike this also. it seems depend on the quickfix - for some it works

[jukzi]

duplicates https://bugs.eclipse.org/bugs/show_bug.cgi?id=509727

see https://stackoverflow.com/a/40625656/9549750 for instructions

[jukzi]

In the reproducer given it is an ASTRewriteCorrectionProposal which is not an FixCorrectionProposal so it fails the instanceof FixCorrectionProposal in org.eclipse.jdt.internal.ui.text.correction.CorrectionMarkerResolutionGenerator.CorrectionMarkerResolution.findOtherMarkers(IMarker[]). One would have to refactor to use FixCorrectionProposalCore instead of ASTRewriteCorrectionProposalCore

[jukzi]

Both classes have been submitted with #815 @robstryker can you help?