Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CleanUpStressTest.testAllCleanUps fails since I20250129-1800 #1990

Closed
jukzi opened this issue Jan 30, 2025 · 4 comments
Closed

CleanUpStressTest.testAllCleanUps fails since I20250129-1800 #1990

jukzi opened this issue Jan 30, 2025 · 4 comments
Assignees
Labels
regression Regression defect test junit test related things

Comments

@jukzi
Copy link
Contributor

jukzi commented Jan 30, 2025

Content not as expected for junit.runner.BaseTestRunner.java expected:<... package for")) { //[ ]$NON-NLS-1$ ...> but was:<... package for")) { //[]$NON-NLS-1$ ...>

org.junit.ComparisonFailure: Content not as expected for junit.runner.BaseTestRunner.java expected:<... package for")) { //[ ]$NON-NLS-1$
...> but was:<... package for")) { //[]$NON-NLS-1$
...>
at org.junit.Assert.assertEquals(Assert.java:117)
at org.eclipse.jdt.ui.tests.quickfix.CleanUpStressTest.testAllCleanUps(CleanUpStressTest.java:5359)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)

for example
https://download.eclipse.org/eclipse/downloads/drops4/I20250129-1800/testresults/html/org.eclipse.jdt.ui.tests_ep435I-unit-linux-x86_64-java21_linux.gtk.x86_64_21.html

@jukzi jukzi added regression Regression defect test junit test related things labels Jan 30, 2025
@jukzi
Copy link
Contributor Author

jukzi commented Jan 30, 2025

caused by eclipse-jdt/eclipse.jdt.core#3631 @jjohnstn
maybe intentional?

@jukzi
Copy link
Contributor Author

jukzi commented Jan 30, 2025

Image

@jjohnstn jjohnstn self-assigned this Jan 30, 2025
@jjohnstn
Copy link
Contributor

@jukzi I'll look at it.

@jjohnstn
Copy link
Contributor

I think that the test should never have added a space within a new NLS marker so I am posting a PR to change it. If my code fixed that, great.

jjohnstn added a commit to jjohnstn/eclipse.jdt.ui-1 that referenced this issue Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression Regression defect test junit test related things
Projects
None yet
Development

No branches or pull requests

2 participants