Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JEEFormAuthenticator does not try to append cookies to a fresh connection #257

Closed
berezovskyi opened this issue Feb 20, 2022 · 1 comment · Fixed by #258
Closed

JEEFormAuthenticator does not try to append cookies to a fresh connection #257

berezovskyi opened this issue Feb 20, 2022 · 1 comment · Fixed by #258

Comments

@berezovskyi
Copy link
Contributor

berezovskyi commented Feb 20, 2022

See https://github.com/eclipse/lyo/blob/7a83a881facdf94bbed032d1f509b2085a39e6b3/client/oslc-client/src/main/java/org/eclipse/lyo/client/JEEFormAuthenticator.java#L102-L107, the filter does nothing unless it's processing a 401 response.

This is likely what causes a performance regression causing excessive number of auth requests with Jazz apps, as reported on the forum.

@berezovskyi
Copy link
Contributor Author

Since AHC4.3, there is a possibility of doing more advanced connection management and pooling in AHC, but we should consider this in connection to #246 to avoid doing work that will become obsolete soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant