Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultiZoomCoordinateSystemMapper Overwritten in Device:init #1686

Closed
amartya4256 opened this issue Dec 19, 2024 · 0 comments · Fixed by #1685
Closed

MultiZoomCoordinateSystemMapper Overwritten in Device:init #1686

amartya4256 opened this issue Dec 19, 2024 · 0 comments · Fixed by #1685
Assignees
@amartya4256
Labels
HiDPI Issues related to High resolution monitors regression Something that used to work

Comments

@amartya4256
Copy link
Contributor

amartya4256 commented Dec 19, 2024 •
edited
Loading

Describe the bug
In the current implementation, the Display seems to never use MultiZoomCoordinateSystemMapper for its coordinateSystemMapper. This mapper is used when rescalingAtRuntime is active but eventually Device:init is called at some point which overwrites the coordinateSystemMapper to a SingleZoomCoordinateSystemMapper. In case of a multi zoom setup, this makes the UI to behave weirdly when you drag and drop a tab across the screens.

To Reproduce

  • Start the SDK product.
  • Drag an editor tab to another monitor with a different DPI
  • The Editor will not open where the preview is pointing to but rather a different location (slightly scaled)
    (My config was: Left monitor - primary - 175%, Right monitor - 100 %; Dragging from right to left)

Expected behavior
The top left corner of the dropped editor should be the same as where the cursor dropped it.

Environment:

  1. Select the platform(s) on which the behavior is seen:
    • All OS
    • Windows
    • Linux
    • macOS

Introduced by #1630
@amartya4256 amartya4256 mentioned this issue Dec 19, 2024
Closed
@fedejeanne fedejeanne added regression Something that used to work HiDPI Issues related to High resolution monitors labels Dec 19, 2024
@amartya4256 amartya4256 mentioned this issue Dec 19, 2024
Merged
amartya4256 added a commit to amartya4256/eclipse.platform.swt that referenced this issue Dec 19, 2024
@amartya4256
Add Null check before assigning coordinateMapper
a0fc6b6 
This commit adds a null check before assigning the coordinate mapper in
the Device::init since it might already be assigned in coordinateMapper.

Fixes eclipse-platform#1686
contributes to eclipse-platform#62 and eclipse-platform#127
fedejeanne pushed a commit that referenced this issue Dec 19, 2024
@amartya4256 @fedejeanne
Add Null check before assigning coordinateMapper
b35fc01 
This commit adds a null check before assigning the coordinate mapper in
the Device::init since it might already be assigned in coordinateMapper.

Fixes #1686
contributes to #62 and #127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amartya4256 amartya4256

Labels
HiDPI Issues related to High resolution monitors regression Something that used to work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Null check before assigning coordinateMapper amartya4256/eclipse.platform.swt
2 participants
@fedejeanne @amartya4256