Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Sequence Diagram, improve ReorderTool to allow lifeline change #522

Open
peransin-obeo opened this issue Dec 4, 2024 · 1 comment
Open
Labels
component: sequences type: enhancement Making an existing feature better

Comments

@peransin-obeo
Copy link
Contributor

peransin-obeo commented Dec 4, 2024

When drag-n-dropping node in Sequence Diagram, it is possible to change elements order but not elements lifeline even if gef/gmf provides indication to do so.

Usecase

See this demo video using org.eclipse.sirius.sample.interactions.design plugin

With proper variables about target node, developer would be able to change its model to move the execution into lifeline 'newParticipant1'.

Analysis

These are the step to introduce this feature:

@mPorhel
Copy link
Contributor

mPorhel commented Jan 16, 2025

This evolution might be more complicated than just addition of the variables as indicated in previous comment.

Several modifications of the editpolicy / move validator / move command builder of the ExecutionEditPart will be needed to allow drag and drop to another lifeline and ensure a consistent layout.

In the VSM this might also lead to the use of a drop tool in combination with the reorder tool. The drop tool will handle the semantic part of the parent change.

Regarding layout and command modifications, they might be in the same area than the changes done for #536 .

@pcdavid pcdavid added type: enhancement Making an existing feature better component: sequences labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: sequences type: enhancement Making an existing feature better
Projects
None yet
Development

No branches or pull requests

3 participants