Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Units of Burned Area and Above Ground Biomass are not consistent, conversion is needed #10

Open
cvitolo opened this issue Apr 23, 2021 · 1 comment
Open

Units of Burned Area and Above Ground Biomass are not consistent, conversion is needed #10

cvitolo opened this issue Apr 23, 2021 · 1 comment
Assignees
@cvitolo
Labels
bug Something isn't working

Comments

@cvitolo
Copy link
Collaborator

cvitolo commented Apr 23, 2021

Describe the bug
In the script src/utils/fuelload.py (line 32) the fuel_load_dataset is calculated as agb_data * ba_data. However units are not consistent: AGB [Mg/hectar] and BA [m2]. A conversion is needed.
cvitolo added a commit that referenced this issue Apr 23, 2021
@cvitolo
Implemented conversion of Burned Area from m2 to hectares before the …
f9306f2 
…fuel load is calculated in fuelload.py. This addresses issue #10.
@cvitolo cvitolo self-assigned this Apr 23, 2021
@cvitolo cvitolo added the bug Something isn't working label Apr 23, 2021
cvitolo added a commit that referenced this issue Apr 23, 2021
@cvitolo
Added new notebook with more concise pre-processing. It includes the …
cb7ff6e 
…conversion to dataframe (model input). It solves issues #10 and #12. It also defines a new threshold for BA (50 hectares, see #11, the new threshold is defined by FDG - fire expert) but a reliable reference source is still not available.
@cvitolo
Copy link
Collaborator Author

cvitolo commented Apr 23, 2021

This issue is solved in branch: cvitolo-patch-1. Will close this issue when the branch is merged into master.

fdg10371 pushed a commit that referenced this issue Jun 21, 2021
@cvitolo
Experiment 2 (#9)
7fe88a5 
* Updated paths

* Implemented conversion of Burned Area from m2 to hectares before the fuel load is calculated in fuelload.py. This addresses issue #10.

* Added new notebook with more concise pre-processing. It includes the conversion to dataframe (model input). It solves issues #10 and #12. It also defines a new threshold for BA (50 hectares, see #11, the new threshold is defined by FDG - fire expert) but a reliable reference source is still not available.

* Notebook notebooks/preprocess_all_in_one.ipynb reformatted using black

* Formatted src/utils/fuelload.py using black

* Minor changes to notebooks/preprocess_all_in_one.ipynb

* renamed notebook and finalised concise version of the data preparation step

* Complete re-write of the data pre-processing step to avoid resampling. This addresses issue #13.

* Added the following amongst predictors: GFED4 basis regions (as categorical variable) and area of grid cell at point (as continuous variable).

* Load formula changed to BA*CC*AGB/AREA

* added log-transformed variables

* updated notebooks with latest run

* model 6h, MAE

* experiments as in ESA-D1 report

* Updated README files to clarify there are two sets of experiments (by wikilimo and ecmwf).

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cvitolo cvitolo

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cvitolo