Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct_data deleting some validation log entries #59

Open
rostal opened this issue Oct 23, 2024 · 0 comments
Open

correct_data deleting some validation log entries #59

rostal opened this issue Oct 23, 2024 · 0 comments

Comments

@rostal
Copy link

rostal commented Oct 23, 2024

@collinschwantes
The validation log is filtered to only get the relevant rows. This includes filtering out blanks in the new_value. This step of filtering should be removed as for example the participant had selected Other, but then the reviewer found that their response was actually an answer they could have selected. So they set the new_val of the other explain question to "" and select the correct choice from among the options.

Please change:

changes <- dplyr::pull(
    dplyr::summarise(
       dplyr::filter(validation_log,
                            is_valid == "FALSE" | is_valid == "F", 
                            !is.na(field), 
                            field != "", 
                            !is.na(entry),
                            entry != "",
                            new_val != ""), 
          n = dplyr::n()),
          n)

to:

changes <- dplyr::pull(
   dplyr::summarise(
      dplyr::filter(validation_log,
                           is_valid == "FALSE" | is_valid == "F", 
                           !is.na(field), 
                           field != "", 
                           !is.na(entry),
                           entry != ""),  # dropped new value = "" as this is sometimes a valid response.
          n = dplyr::n()),
         n)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant