Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the beat matrix contains the beats #251

Open
magwas opened this issue Mar 15, 2019 · 6 comments
Open

the beat matrix contains the beats #251

magwas opened this issue Mar 15, 2019 · 6 comments

Comments

@magwas
Copy link
Member

magwas commented Mar 15, 2019

Behaviour: Schulze method/compute initial beat matrix;the beat matrix contains the beats

@tested_feature("Schulze method")

@tested_operation("compute initial beat matrix")

@tested_behaviour("the beat matrix contains the beats")

m[a,b][forward] contains the number of votes casts where a beats b m[b,a][backward] contains the number of votes cast where b beats a

Deviation in model

@valentinbujdoso
Copy link
Contributor

valentinbujdoso

@valentinbujdoso
Copy link
Contributor

As far as I understand the ticket. I have to implement a BeatTable normalizeBeatMatrix(List castVotes); function. I checked the CastVote class and the RankedChoice class too. However I just found choiceId in the RankedChoice. So I can create an order based on the RankedChoices rank but only for the choiceIds. The problem is that the BeatTables matrix contains choices.
So my question is that how can I create a full valid Choice from a choiceId? Where can I find the relation between choiceIds and Choice objects?

@magwas
Copy link
Member Author

magwas commented Mar 28, 2019

Oops, a design inconsistency again...
Can you refactor BeatTable to use choice ID instead of Choice object?

@valentinbujdoso
Copy link
Contributor

yeah sure

@magwas
Copy link
Member Author

magwas commented Mar 28, 2019

thx

magwas pushed a commit that referenced this issue Mar 29, 2019
* The beat matrix contains the beats #251
@valentinbujdoso
Copy link
Contributor

Done

magwas pushed a commit that referenced this issue Apr 11, 2019
* The beat matrix contains the beats #251
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants