Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset books state WAS:Mark books as "unread" #16

Open
spencerandhill opened this issue Jan 10, 2025 · 9 comments
Open

Reset books state WAS:Mark books as "unread" #16

spencerandhill opened this issue Jan 10, 2025 · 9 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@spencerandhill
Copy link

Hello!
Thank you for your great work, I really enjoy bubble2 :)

Unfortunately, I can't find a function to mark books as “unread”. Whenever I accidentally open a book, I can't mark it as “unread” anymore.

-> Am I mistaken or does this function not exist in bubble2?

Best regards

@edeso
Copy link
Owner

edeso commented Jan 12, 2025

hey @spencerandhill , pleasure to hear Bubble2 is to your liking.

wrt. read/unread status of books - there is actually none of that. what the app does is merely remembering the last page visited. the filters then interpret the page number as follows
Status - Condition
Read - current page is last page of book
Unread - current page not 0 (never opened)
Unfinished - current page not the last page
Reading - current page not 0 or last page, so all books neither Unread nor Finished

see source here
https://github.com/edeso/bubble2/blob/master/app/src/main/java/com/nkanaev/comics/fragment/LibraryBrowserFragment.java#L515-L534

@edeso edeso added the help wanted Extra attention is needed label Jan 12, 2025
@spencerandhill
Copy link
Author

spencerandhill commented Jan 13, 2025

Hey Edeso! That's a shame, I was hoping to bring some order into it. It's about the "last viewed" view in the screenshot in the attachment. Everything is fine here now, but if I open another book, for example, which is not yet "on the line", I no longer have an overview.

Can this be changed? Or would you include this as an enhancement request?

Best regards

@edeso
Copy link
Owner

edeso commented Jan 13, 2025

sorry Jan, still don't understand what you are trying to achieve. please try to describe what you do and when the result does not meet you expectations in more detail.

why does the filter 'Unfinished' not meet your expectations?

@spencerandhill
Copy link
Author

spencerandhill commented Jan 13, 2025

If i set the filter to "right in the middle" (I don't know the exact english word, I'm using it in german, where it's called "mittendrin"), then bubble show's me books that are NOT started, but just "sneaked into". I can set those to page 1, but I cannot set page 0, so that they don't show up as "started but not finished". See attachment.

In the attachment you can see, that I'm reading 1 book (page 36/260) and 3 books, that I cannot "reset" to page 0. That's the problem, I cannot set Books to "unread", so that they don't show up as "started". I can only set them to page 1 / 260 and therefore they show up in the filter, even if I'm not reading those books.

Best

@edeso
Copy link
Owner

edeso commented Jan 13, 2025

ok, i see what you are doing. 'Mittendrin' equals 'Currently Reading'.

the functionality you are looking for is what basically the section 'Recent' ('Zuletzt gelesen') in the overview is meant for. so you basically do not filter by default but check the first entry of 'Recent' and that is the book you are currently reading.

any specific reason why you do not use the ap this way?

i see that having the possibility to reset the current page to zero might be wanted under specific circumstances. let me add this as a feature request. any idea on how to realise that, apart from a long press popup menu on the comic book listing?

@spencerandhill
Copy link
Author

spencerandhill commented Jan 13, 2025

"any specific reason why you do not use the ap this way?"
Well yes, it is sorted, but that's not the point. It's still presenting me books as "recent", even if I accidentally tapped on a book. It just feels 'wrong' to have these books in the list of recent books. I don't think, that there should be some logic to automatically detect unread books, but the possibility to 'reset' the current page of a book to 0 should be fine.

Yes, it could be done via long-press popup menu on the comic book listing (that was my first intuitive try), or maybe (might be easier) just make the page-counter inside an OPENED book slide from page 0 to max, instead of page 1 to max. So that you can open a book and set the page to 0 to reset the book (could be done without any page shown/blank page, or with a generic page that says 'mark book as unread by setting page to 0').

Best.

@edeso
Copy link
Owner

edeso commented Jan 13, 2025

hehe, yeah. how'd Bubble2 know that you accidentially opened them ;). technically you recently opened them.

for a proper reset we'd need to unset page and last time visited in the database, so a popup menu with a reset entry sounds more appealing, although needs more effort to implement. surely sliding the page to zero might work, but i don't see people expecting that functionality intuitively. so from an UX stand point it'd not be a good choice.

@spencerandhill
Copy link
Author

Completely understandable!
I'm fine with both solutions ^^

So thank you for adding this as a feature request! If there's anything I could do to support you, let me know.

Best

@edeso
Copy link
Owner

edeso commented Jan 13, 2025

any support is welcome! ideally you contribute by adding a PR with functionality you miss or fixes for bugs. additionally translations need to be improved/added.

and last but not least, if you feel generous you may send some money or crypto my way.

enjoy and sunny regards ..ede

@edeso edeso added the enhancement New feature or request label Jan 13, 2025
@edeso edeso changed the title Mark books as "unread" Reset books state WAS:Mark books as "unread" Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants